Fix inlay hint location links problem#167886
Merged
Merged
Conversation
jrieken
suggested changes
Dec 5, 2022
jrieken
left a comment
Contributor
There was a problem hiding this comment.
Thanks so far. Left a suggestion to avoid a dependency between inlay and goto contributions
jrieken
suggested changes
Dec 12, 2022
jrieken
suggested changes
Dec 13, 2022
| } | ||
|
|
||
| override runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, arg?: SymbolNavigationAnchor | unknown, range?: Range): Promise<void> { | ||
| override runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: [ICodeEditor, SymbolNavigationAnchor | unknown, Range | undefined]): Promise<void> { |
Contributor
There was a problem hiding this comment.
I don't think this change is needed and I do believe that it will break existing callers
Contributor
Author
There was a problem hiding this comment.
There was a mismatch between callers and this before my PR, and it was the reason it wasn't working correctly. So either the caller in editorExtensions.ts:455 or here needs to be changed. And the caller is more generic, so I think changing here is correct. And other inherited classes of EditorAction2 all have an args argument as third argument, and no more arguments:
src/vs/editor/contrib/gotoSymbol/browser/goToCommands.ts
106: override runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: [ICodeEditor, SymbolNavigationAnchor | unknown, Range | undefined]): Promise<void> {
src/vs/editor/contrib/folding/browser/folding.ts
529: public override runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: T): void | Promise<void> {
src/vs/editor/browser/coreCommands.ts
36: public runEditorCommand(accessor: ServicesAccessor | null, editor: ICodeEditor, args?: Partial<T> | null): void {
1885: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: unknown): void {
1961: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: unknown): void {
2095: public runEditorCommand(accessor: ServicesAccessor | null, editor: ICodeEditor, args: unknown): void | Promise<void> {
2110: public runEditorCommand(accessor: ServicesAccessor | null, editor: ICodeEditor, args: unknown): void | Promise<void> {
src/vs/editor/browser/editorExtensions.ts
276: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: any): void {
377: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: any): void | Promise<void> {
src/vs/editor/contrib/wordOperations/browser/wordOperations.ts
44: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: any): void {
333: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: any): void {
src/vs/editor/contrib/codeAction/browser/codeActionCommands.ts
210: public runEditorCommand(_accessor: ServicesAccessor, editor: ICodeEditor, userArgs: any) {
src/vs/workbench/contrib/testing/browser/testingOutputPeek.ts
1675: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor) {
1705: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor) {
1723: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor) {
1750: public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor) {
Contributor
There was a problem hiding this comment.
jrieken
reviewed
Dec 15, 2022
jrieken
left a comment
Contributor
There was a problem hiding this comment.
I pushed some changes as described and I am going ahead to merge this PR. Thanks!
jrieken
approved these changes
Dec 15, 2022
lszomoru
approved these changes
Dec 15, 2022
Contributor
Author
|
@jrieken the problem appears again after your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #167564
The changes in
goToDefinitionAtPosition.tsdisable decoration of the nearest token on hover with Ctrl, and the other changes fix the target when clicking. I didn't find out how to add a test for it but I can do that with some mentoring if needed.