🔨 Add "Focus Breadcrumb" to command palette#166461
Merged
jrieken merged 5 commits intomicrosoft:mainfrom Nov 17, 2022
Merged
Conversation
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
jrieken
requested changes
Nov 16, 2022
Member
jrieken
left a comment
There was a problem hiding this comment.
Thanks so far. This is looking good and my feedback is about removing now obsolete code.
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
joaomoreno
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166213
Just notice that I had to change the localized text ID for the
breadcrumbs.focusAndSelectcommand tocmd.focusAndSelect(fromcmd.focuswhich had to be used for the actualbreadcrumbs.focuscommand).An idea is to also include the
Focus and Select Breadcrumbson the command palette.