Skip to content

Move css rules from inPlaceReplace.ts into inPlaceReplace.css#166098

Merged
aeschli merged 21 commits intomicrosoft:mainfrom
Kalmaegi:use_css_variables_second
Nov 16, 2022
Merged

Move css rules from inPlaceReplace.ts into inPlaceReplace.css#166098
aeschli merged 21 commits intomicrosoft:mainfrom
Kalmaegi:use_css_variables_second

Conversation

@Kalmaegi
Copy link
Contributor

@Kalmaegi Kalmaegi commented Nov 11, 2022

For #165169

  • src/vs/editor/contrib/inPlaceReplace/browser/inPlaceReplace.ts
  • src/vs/editor/contrib/inlineCompletions/browser/ghostTextWidget.ts
  • src/vs/editor/contrib/links/browser/links.ts
    x src/vs/editor/contrib/find/browser/findOptionsWidget.ts

@Kalmaegi Kalmaegi force-pushed the use_css_variables_second branch from 9889cb3 to 865e7ca Compare November 12, 2022 02:06
@Kalmaegi
Copy link
Contributor Author

@microsoft-github-policy-service agree

aeschli
aeschli previously approved these changes Nov 14, 2022
@aeschli aeschli added this to the November 2022 milestone Nov 14, 2022
@aeschli aeschli added themes Color theme issues feature-request Request for new features or functionality labels Nov 14, 2022
@dbaeumer dbaeumer requested review from aeschli and dbaeumer November 14, 2022 13:48
dbaeumer
dbaeumer previously approved these changes Nov 14, 2022
@aeschli aeschli changed the title #165169 Move css rules from inPlaceReplace.ts into inPlaceReplace.css Move css rules from inPlaceReplace.ts into inPlaceReplace.css Nov 14, 2022
@aeschli
Copy link
Contributor

aeschli commented Nov 14, 2022

Thanks @weartist !

@Kalmaegi Kalmaegi dismissed stale reviews from dbaeumer and aeschli via 9a5486c November 15, 2022 13:56
@Kalmaegi
Copy link
Contributor Author

@aeschli I fixed the code conflict. hope it was right

@Kalmaegi
Copy link
Contributor Author

@aeschli the findOptionsWidget has been merged with other people's changes, i remove commit of this file

dbaeumer
dbaeumer previously approved these changes Nov 16, 2022
@Kalmaegi
Copy link
Contributor Author

@aeschli I moved the 'links.css color' position, there was a small mistake in a previous commit https://github.com/microsoft/vscode/pull/166258/files/63816e279be3c11d4a44ac95721dfb31bb6230ae

@aeschli aeschli merged commit d34224b into microsoft:main Nov 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature-request Request for new features or functionality themes Color theme issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants