Reset value to an empty string when undefined or null#165721
Merged
alexdima merged 5 commits intomicrosoft:mainfrom Nov 16, 2022
Merged
Reset value to an empty string when undefined or null#165721alexdima merged 5 commits intomicrosoft:mainfrom
alexdima merged 5 commits intomicrosoft:mainfrom
Conversation
alexdima
requested changes
Nov 14, 2022
Member
alexdima
left a comment
There was a problem hiding this comment.
Thanks for pointing this out. The fix should be to throw when an invalid argument is passed in.
alexdima
approved these changes
Nov 16, 2022
alexr00
approved these changes
Nov 16, 2022
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undefined and null values are not properly handled. When an undefined value is passed in Monaco, the textModel will call factory.create on an undefined value which will throw an undefined error.
Also, if a null value is passed, since the logic returns without updating the value, the previous data will still be displayed.
A solution is to reset the value to an empty string.
Issue: microsoft/monaco-editor#3414