Skip to content

Reduce registerThemingParticipant#165575

Merged
hediet merged 2 commits intomicrosoft:mainfrom
QaidVoid:vpln
Nov 15, 2022
Merged

Reduce registerThemingParticipant#165575
hediet merged 2 commits intomicrosoft:mainfrom
QaidVoid:vpln

Conversation

@QaidVoid
Copy link
Contributor

@QaidVoid QaidVoid commented Nov 5, 2022

Ref #165169

  • src/vs/editor/browser/viewParts/lineNumbers/lineNumbers.ts
  • src/vs/editor/contrib/find/browser/findOptionsWidget.ts

@QaidVoid QaidVoid changed the title Use CSS variables for line numbers Reduce registerThemingParticipant Nov 7, 2022
@roblourens roblourens assigned rebornix and hediet and unassigned roblourens Nov 9, 2022
@hediet
Copy link
Member

hediet commented Nov 9, 2022

Thanks for this PR! Can you look into the CI failure?

@QaidVoid
Copy link
Contributor Author

I'm not sure why it failed before. It seems to be passing now, though.

Copy link
Member

@hediet hediet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@hediet hediet added this to the November 2022 milestone Nov 14, 2022
@hediet hediet merged commit 085c409 into microsoft:main Nov 15, 2022
@QaidVoid QaidVoid deleted the vpln branch November 19, 2022 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants