improve Git Bash integration on Windows (#151105)#165428
Merged
meganrogge merged 2 commits intomicrosoft:mainfrom Nov 9, 2022
Okeanos:improve-git-bash-integration
Merged
improve Git Bash integration on Windows (#151105)#165428meganrogge merged 2 commits intomicrosoft:mainfrom Okeanos:improve-git-bash-integration
meganrogge merged 2 commits intomicrosoft:mainfrom
Okeanos:improve-git-bash-integration
Conversation
Bash sessions should be started as interactive (`-i`) sessions to enable history commands by default. This is the same setup used by the official Git for Windows JSON fragment extension for Windows Terminal. This does not fix the issue at this time, however, because bash signal handling on Windows for quit/close/kill signals does not work as expected.
Tyriar
approved these changes
Nov 9, 2022
meganrogge
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash sessions should be started as interactive (
-i) sessions to enable history commands by default.This is the same setup used by the official Git for Windows JSON fragment extension for Windows Terminal.
This does not fix the issue at this time, however, because bash signal handling on Windows for quit/close/kill signals does not work as expected.