Interactive window- don't leave space for insert toolbar#164760
Closed
r3m0t wants to merge 1 commit into
Closed
Conversation
r3m0t
commented
Oct 26, 2022
| } | ||
|
|
||
| private _computeBottomToolbarDimensions(compactView: boolean, insertToolbarPosition: 'betweenCells' | 'notebookToolbar' | 'both' | 'hidden', insertToolbarAlignment: 'left' | 'center', cellToolbar: 'right' | 'left' | 'hidden'): { bottomToolbarGap: number; bottomToolbarHeight: number } { | ||
| private _computeBottomToolbarDimensions(compactView: boolean, insertToolbarBetweenCells: boolean, insertToolbarAlignment: 'left' | 'center', cellToolbar: 'right' | 'left' | 'hidden'): { bottomToolbarGap: number; bottomToolbarHeight: number } { |
Contributor
Author
There was a problem hiding this comment.
!insertToolbarBetweenCells should take precedence over insertToolbarAlignment === 'left'
r3m0t
commented
Oct 26, 2022
| private _computeBottomToolbarDimensions(compactView: boolean, insertToolbarPosition: 'betweenCells' | 'notebookToolbar' | 'both' | 'hidden', insertToolbarAlignment: 'left' | 'center', cellToolbar: 'right' | 'left' | 'hidden'): { bottomToolbarGap: number; bottomToolbarHeight: number } { | ||
| private _computeBottomToolbarDimensions(compactView: boolean, insertToolbarBetweenCells: boolean, insertToolbarAlignment: 'left' | 'center', cellToolbar: 'right' | 'left' | 'hidden'): { bottomToolbarGap: number; bottomToolbarHeight: number } { | ||
| if (insertToolbarAlignment === 'left' || cellToolbar !== 'hidden') { | ||
| return { |
Contributor
Author
There was a problem hiding this comment.
can we leave a smaller gap when cellToolbar !== 'hidden' && !insertToolbarBetweenCells
Collaborator
There was a problem hiding this comment.
yeah, it seems like this also check if the toolbar is even being inserted.
Contributor
Author
|
I have rebased to #181949 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive window is more compact than Notebook now, by not leaving space for the insert cell toolbar(which has no items anyway in the interactive window)
However, you need to apply
to see this. With the default setting, the space is reserved anyway for the notebook cell toolbar.
Note, readonly notebooks (other than interactive window) are still leaving space for the insert cell toolbar even though it has no items.