Fix tasks status incorrect #163393#163952
Merged
meganrogge merged 7 commits intomicrosoft:mainfrom Nov 3, 2022
Merged
Conversation
Co-authored-by: jeanp413 <jeanp413@hotmail.com>
Contributor
Author
|
@microsoft-github-policy-service agree |
1 similar comment
Contributor
Author
|
@microsoft-github-policy-service agree |
jeanp413
reviewed
Oct 19, 2022
jeanp413
reviewed
Oct 19, 2022
Contributor
Author
|
Updated, see diff here, and local integration test passed |
Contributor
|
cc @meganrogge |
meganrogge
reviewed
Nov 2, 2022
meganrogge
reviewed
Nov 2, 2022
meganrogge
reviewed
Nov 2, 2022
meganrogge
reviewed
Nov 2, 2022
meganrogge
reviewed
Nov 2, 2022
meganrogge
reviewed
Nov 2, 2022
meganrogge
reviewed
Nov 2, 2022
meganrogge
reviewed
Nov 2, 2022
meganrogge
approved these changes
Nov 2, 2022
Collaborator
meganrogge
left a comment
There was a problem hiding this comment.
Thanks for working on this 👍🏼
alexr00
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163393
How to Test
Open vscode with source with
tasks.jsondefined like below, tasks status should be correct after task is done(Use
cmd+shift+bto start task){ // See https://go.microsoft.com/fwlink/?LinkId=733558 // for the documentation about the tasks.json format "version": "2.0.0", "tasks": [ { "label": "echo11", "type": "shell", "command": "${workspaceFolder}/a.sh", "presentation": { "echo": true, "reveal": "always", "focus": false, "panel": "new", "showReuseMessage": true, "clear": false }, "problemMatcher": [], "group": { "kind": "build", "isDefault": true } } ] }{ // See https://go.microsoft.com/fwlink/?LinkId=733558 // for the documentation about the tasks.json format "version": "2.0.0", "tasks": [ { "label": "echo11", "type": "shell", "command": "${workspaceFolder}/a.sh", "presentation": { "echo": true, "reveal": "always", "focus": false, "showReuseMessage": true, "clear": false }, "problemMatcher": [], "group": { "kind": "build", "isDefault": true }, "runOptions": { "instanceLimit": 3 } } ] }File
a.shcan be likeecho hello sleep 3