Include newline when expanding line selection #15564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaiwood, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima, @Agetorp and @egamma to be potential reviewers. |
Contributor
Author
|
Oh, and for completeness: ping @prashaantt (might be interested because he mentioned this after #950 was already merged) |
8299d09 to
083dff8
Compare
Member
|
Thank you! ❤️ |
|
is there a way to select only the block of code on the line and not the newline? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14485
A note for future reference: This PR leaves the current behaviour when selecting wrapped long lines intact / in the same state it is currently implemented (it handles wrapped lines as if they are real lines).
Although I disagree with the current implementation – selecting a line should select the whole real line, because otherwise you semantically cut a real line in half – the way moving up/down in the editor treats those wrapped lines as real lines anyway, so the implementation is at least consistent.
If the day comes where this movement behaviour is changed,
expandLineSelectionshould be changed as well to stay consistent.