fix shell integration issues after clearing#151223
Merged
meganrogge merged 2 commits intomainfrom Jun 3, 2022
Merged
Conversation
Collaborator
Author
|
not sure why this isn't happening already when the prompt gets printed |
Collaborator
Author
|
oh I think what happens is the top line is just retained of the prompt and not cleared |
Collaborator
Author
|
which explains why xterm.js doesn't parse anything even though the prompt appears to show up after the |
Collaborator
Author
prompt.mov |
roblourens
approved these changes
Jun 3, 2022
Tyriar
approved these changes
Jun 3, 2022
Contributor
Tyriar
left a comment
There was a problem hiding this comment.
Similar thing to what was there before, 👍 if it works on bash, zsh and pwsh. pwsh works fine currently probably because it gets the command line set explicitly so prompt start/command start aren't as important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #145148 fixes #151217