Skip to content

Cache release notes. Fixes #13257#15050

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
olingern:olingern/cache-release-notes
Dec 13, 2016
Merged

Cache release notes. Fixes #13257#15050
joaomoreno merged 1 commit intomicrosoft:masterfrom
olingern:olingern/cache-release-notes

Conversation

@olingern
Copy link
Copy Markdown
Contributor

@olingern olingern commented Nov 5, 2016

No description provided.

@msftclas
Copy link
Copy Markdown

msftclas commented Nov 5, 2016

Hi @olingern, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Copy link
Copy Markdown
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the lack of guidance so far.

When I said keep them in memory I literally meant it as a variable in some scope. Don't use the storage service, since it will polute the storage and we don't care about having this information surviving between executions.

Create an object, next to loadReleaseNotes that will serve as a cache and use version as a key for that cache.

@olingern
Copy link
Copy Markdown
Contributor Author

olingern commented Nov 8, 2016

No problem!

I refactored to use a string instead of the storage service.

Is there a reason you'd prefer the cache be an object with a key over a regular string? Is there a use case where multiple versions would be cached and need to be accessed directly on an object?

@msftclas
Copy link
Copy Markdown

msftclas commented Nov 8, 2016

@olingern, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@joaomoreno
Copy link
Copy Markdown
Member

Yeah, using the version as a key lets you read the current version's release notes as well as the next one, once you get an update notification.

@olingern olingern changed the title Cache release notes using workspaceStorage. Fixes #13257 Cache release notes. Fixes #13257 Nov 8, 2016
@olingern
Copy link
Copy Markdown
Contributor Author

olingern commented Nov 8, 2016

@joaomoreno Got it. I updated the PR and rebased commit history to be a bit more clean. Let me know if this all goods good and if there's anything I can do to help get the tests passing.

@joaomoreno
Copy link
Copy Markdown
Member

Looks better! 👍

The problem is you need to merge the latest master onto your branch, do you mind doing this? That way our continuous integration tests will run on the PR.

@olingern
Copy link
Copy Markdown
Contributor Author

@joaomoreno I pulled the latest master branch, but opening the release notes opens in the browser each time now.

@joaomoreno joaomoreno added this to the November 2016 milestone Nov 10, 2016
@olingern
Copy link
Copy Markdown
Contributor Author

@joaomoreno opting to close this as I see the latest version of Insider's release opens in the browser.

@joaomoreno
Copy link
Copy Markdown
Member

@olingern The insider release will always open in the browser. The stable one opens in the product.

@joaomoreno joaomoreno modified the milestones: January 2017, November 2016 Dec 6, 2016
@joaomoreno joaomoreno merged commit 5c5a630 into microsoft:master Dec 13, 2016
@joaomoreno
Copy link
Copy Markdown
Member

Thanks for the PR!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants