Skip to content

feat: inlay hints displayStyle#150118

Merged
jrieken merged 1 commit intomicrosoft:mainfrom
pksunkara:main
May 23, 2022
Merged

feat: inlay hints displayStyle#150118
jrieken merged 1 commit intomicrosoft:mainfrom
pksunkara:main

Conversation

@pksunkara
Copy link
Copy Markdown
Contributor

This PR fixes #148868

We now have two styles for inlay hints. code (default) and widget.

@ghost
Copy link
Copy Markdown

ghost commented May 22, 2022

CLA assistant check
All CLA requirements met.

@pksunkara
Copy link
Copy Markdown
Contributor Author

@jrieken Here's the PR.

@jrieken jrieken added this to the May 2022 milestone May 23, 2022
@jrieken
Copy link
Copy Markdown
Member

jrieken commented May 23, 2022

@pksunkara Thanks. This is looking good and I could merge this. Tho, we have discussed the setting in our team channel and have agreed on a different name/value. We think editor.inlayHint.padding with true|false makes most sense. So, if you want to update your PR according than that would be awesome

Copy link
Copy Markdown
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jrieken jrieken merged commit bd3977b into microsoft:main May 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inlay hints appearance is different in 1.67.0

3 participants