Skip to content

Changing dependency syntax in extensions/markdown-math#149501

Closed
PF4Public wants to merge 1 commit intomicrosoft:mainfrom
PF4Public:main
Closed

Changing dependency syntax in extensions/markdown-math#149501
PF4Public wants to merge 1 commit intomicrosoft:mainfrom
PF4Public:main

Conversation

@PF4Public
Copy link
Copy Markdown

Changing dependency syntax in extensions/markdown-math
for yarn not to call git, but to use a simple cacheable file instead.

This PR fixes #149291

@JacksonKearl JacksonKearl self-requested a review May 13, 2022 21:58
JacksonKearl
JacksonKearl previously approved these changes May 13, 2022
@mjbvz mjbvz enabled auto-merge (squash) May 13, 2022 23:34
@mjbvz mjbvz added this to the May 2022 milestone May 13, 2022
auto-merge was automatically disabled May 14, 2022 01:01

Head branch was pushed to by a user without write access

@PF4Public
Copy link
Copy Markdown
Author

PF4Public commented May 14, 2022

Looks like yarn.lock should be intact in PRs. I've excluded it from the commit. But someone should do yarn install after merging. Idk, maybe you have a bot for that…

@mjbvz mjbvz enabled auto-merge (squash) May 16, 2022 15:22
@mjbvz
Copy link
Copy Markdown
Collaborator

mjbvz commented May 16, 2022

Actually can you please add the yarn lock change back in. Otherwise I'll have to submit another PR updating the yarn.lock after merging this

Changing dependency syntax in extensions/markdown-math
for yarn not to call git, but to use a simple cacheable file instead.
auto-merge was automatically disabled May 16, 2022 19:00

Head branch was pushed to by a user without write access

@PF4Public
Copy link
Copy Markdown
Author

Sure :)

@mjbvz mjbvz added the on-release-notes Issue/pull request mentioned in release notes label May 19, 2022
@mjbvz
Copy link
Copy Markdown
Collaborator

mjbvz commented May 19, 2022

Sorry, I actually need to make this change myself. Otherwise there's no way to get the PR checks to pass

Will submit PR shortly

@mjbvz mjbvz closed this May 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

on-release-notes Issue/pull request mentioned in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please do not use "https://…git" URL scheme in extensions/markdown-math/package.json

3 participants