Handle multiline commit messages when creating PR#149426
Merged
joaomoreno merged 3 commits intomicrosoft:mainfrom May 18, 2022
rojvv:main
Merged
Handle multiline commit messages when creating PR#149426joaomoreno merged 3 commits intomicrosoft:mainfrom rojvv:main
joaomoreno merged 3 commits intomicrosoft:mainfrom
rojvv:main
Conversation
Contributor
rojvv
commented
May 13, 2022
- This makes the body of the pull request non-empty when the commit message consists of more than one line.
- The GitHub web client fills the body the same way, too, when you create a pull request.
- Some commit messages consist of more than one line, like this one, which is giving more detail about the commit and can be used as a shortcut to not write the same text when opening a pull request and on GitHub.
- Without these changes, the pull request title will be messed up if the commit message is similar to this.
- This makes the body of the pull request non-empty when the commit message consists more than one line. - The GitHub web client fills the body the same way, too, when you create a pull request. - Some commit messages consist more than one line, like this one, which is giving more detail about the commit, and can be used as a shortcut to not write the same text when opening a pull request and on GitHub. - Without these changes, the pull request title will be messed up if the commit message is similar to this.
joaomoreno
approved these changes
May 18, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.