Added extension search text length to telemetry#148785
Added extension search text length to telemetry#148785isidorn merged 5 commits intomicrosoft:mainfrom
Conversation
|
This looks ok to me, but I leave the final review to @sandy081 as he would know best if this catches all the cases where we have the @prashantvc did you try this out, if it catches the data you need in all cases. To build VS Code out of source just follow this doc https://github.com/microsoft/vscode/wiki/How-to-Contribute |
Yes, I tried it locally on my machine! It seems to capture the data that I need |
| withSearchTextLength(length: number): Query { | ||
| return new Query({ ...this.state, searchTextLength: length }); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not the right location to add data for telemetry and this method is not needed. You can add following code
searchtextLength: this.searchText.length
in the following location
and add this property in the telemetry classification here
and
There was a problem hiding this comment.
Thanks for review fixing them now
|
@prashantvc let us know when this is good for review again. Thank you |
It's ready now |
|
Looks good, thanks a lot @prashantvc |
This PR adds the length of search text to the telemetry