Fix infinite loop in the disassembly view#148556
Merged
roblourens merged 3 commits intomicrosoft:mainfrom May 6, 2022
Merged
Conversation
This change reuses the existing binary search algorithm, generalizing it to work with non-Array containers. Fixes microsoft#147163.
|
|
roblourens
requested changes
May 6, 2022
Member
roblourens
left a comment
There was a problem hiding this comment.
Looks good, just a couple comments, thank you!
roblourens
approved these changes
May 6, 2022
sbatten
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reuses the existing binary search algorithm, generalizing it to
work with non-Array containers. Fixes #147163.
This PR fixes #147163. The underlying algorithm is unit tested; the UI can been verified by following the associated issue's reproduction instructions both on modified mock debugger extension, as well as on unmodified one (omitting step 2).