Skip to content

Add high contrast light theme on monaco editor#148249

Closed
CGNonofr wants to merge 2 commits intomicrosoft:mainfrom
CodinGame:monaco-add-hc-light-theme
Closed

Add high contrast light theme on monaco editor#148249
CGNonofr wants to merge 2 commits intomicrosoft:mainfrom
CodinGame:monaco-add-hc-light-theme

Conversation

@CGNonofr
Copy link
Copy Markdown
Contributor

@CGNonofr CGNonofr commented Apr 27, 2022

@CGNonofr CGNonofr changed the title Add hc light theme on monaco editor Add high contrast light theme on monaco editor Apr 27, 2022
@CGNonofr CGNonofr force-pushed the monaco-add-hc-light-theme branch from 2c3be9c to 0f7abe6 Compare April 27, 2022 10:17
@aeschli aeschli added this to the May 2022 milestone Apr 28, 2022
@aeschli
Copy link
Copy Markdown
Contributor

aeschli commented Apr 28, 2022

Looks good!

@CGNonofr
Copy link
Copy Markdown
Contributor Author

CGNonofr commented May 6, 2022

Looks good!

Is there something I'm expected to do to get this PR merged?

@aeschli aeschli requested review from aeschli and alexdima May 6, 2022 13:14
@aeschli
Copy link
Copy Markdown
Contributor

aeschli commented May 9, 2022

'Hygiene and Layering ' is not completing. Any idea @lszomoru ?

@alexdima
Copy link
Copy Markdown
Member

alexdima commented May 10, 2022

The branch is a bit old and doesn't contain the latest CI build definition. main needs to be merged into it. Unfortunately we can't push to the source branch of this PR because the PR was created without that checkbox:

remote: Permission to codingame/vscode.git denied to alexdima.
fatal: unable to access 'https://github.com/codingame/vscode/': The requested URL returned error: 403

@alexdima alexdima added the on-release-notes Issue/pull request mentioned in release notes label May 10, 2022
@alexdima
Copy link
Copy Markdown
Member

alexdima commented May 10, 2022

I've ported the changes to a new PR at #149165 but this PR will receive proper thanks via the Thank You tool.

@alexdima alexdima closed this May 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

on-release-notes Issue/pull request mentioned in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Support light high contrast theme

3 participants