Conversation
roblourens
approved these changes
Mar 25, 2022
| @@ -1517,15 +1519,8 @@ export class SettingsEditor2 extends EditorPane { | |||
|
|
|||
| private layoutTrees(dimension: DOM.Dimension): void { | |||
Member
There was a problem hiding this comment.
Could be renamed to avoid confusion
Collaborator
Author
There was a problem hiding this comment.
Renamed to layoutSplitView
fec95db to
aeae572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145572
Because one specifies a
layoutfield when adding views to the splitview, the container layout calls should happen there, instead, otherwise the layouts are happening in the wrong order.Thanks to @joaomoreno for pointing out what was going on at #145572 (comment)!