Adjust Settings editor narrow total width#145358
Merged
Conversation
miguelsolorio
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #145243
Fixes #143690
We increase the Settings editor narrow total width. In turn, the ToC only shows up when the Settings editor is wide enough.
Pros:
Cons:
Considering how users who use VS Code with a narrower width might get annoyed at the ToC not showing up, a better solution is probably to figure out how to add a horizontal scrollbar to just the editor side in case it is too narrow.
Adding @misolori as a reviewer for thoughts on this issue.
Also CC @stevencl.