support Copy as HTML in the terminal#144784
Merged
meganrogge merged 7 commits intomainfrom Mar 14, 2022
Merged
Conversation
meganrogge
commented
Mar 9, 2022
| e.clipboardData.setData('text/html', selectionAsHtml); | ||
| e.preventDefault(); | ||
| } | ||
| document.addEventListener('copy', listener); |
Collaborator
Author
There was a problem hiding this comment.
I tried clipboard.writeHTML and that worked, but was complaining about the cross platform import violation from electron
Collaborator
Author
There was a problem hiding this comment.
also tried
const type = 'text/html';
const blob = new Blob([selectionAsHtml], { type });
const data = [new ClipboardItem({ [type]: blob })];
await navigator.clipboard.write(data);
per the notebook API example, but hit this known issue
Member
There was a problem hiding this comment.
@rebornix do you have any thoughts/experiences here? I'd really prefer to use the navigator.clipboard API.
@meganrogge does it work if you request permissions via navigator.permission explicitly?
Collaborator
Author
There was a problem hiding this comment.
navigator.permissions is readonly
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/permissions
meganrogge
commented
Mar 9, 2022
meganrogge
commented
Mar 9, 2022
Tyriar
requested changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #20813