This will look for Visual Studio in the Correct directory.#143479
This will look for Visual Studio in the Correct directory.#143479deepak1556 merged 14 commits intomainfrom unknown repository
Conversation
ghost
left a comment
There was a problem hiding this comment.
I have checked the code and it works in my case
|
I've tried this before, and the |
|
Yaa this will actually fix the issue and the next time no other will have the same issue. Just waiting for the maintainer to merge this pr |
|
I tested the code and it worked totally fine. Let's see when the maintainer merges this pr. |
|
After this fix the issue will completely resolve. |
|
@paulacamargo25 please approve all the pending workflow. |
|
@paulacamargo25 if there's something wrong in the code please let me know. |
|
@rzhao271 waiting for your approval. |
|
It is currently endgame/testing week. PR LGTM, but I plan on merging it next week. |
|
No issues. Waiting for the endgame to end. |
|
Merging to address build failure https://github.com/microsoft/vscode/runs/5352655839?check_suite_focus=true |
|
Thanks for the PR! |
Previously running yarn install was looking for visual studio workload in the programfilesx86 folder now this fix will check for visual studio in the programfilesx86 in the first and then will look on programFiles folder.
This fix will help Visual Studio 2022 users as it is a 64b bit software so it goes to programFiles folder not in ProgramFilesx86.
This PR fixes #143478