Skip to content

allow creating a terminal in an empty workspace#141971

Merged
meganrogge merged 2 commits intomainfrom
merogge/workspace
Feb 2, 2022
Merged

allow creating a terminal in an empty workspace#141971
meganrogge merged 2 commits intomainfrom
merogge/workspace

Conversation

@meganrogge
Copy link
Collaborator

This pr fixes #141463

@meganrogge meganrogge changed the title fix #141463 allow creating a terminal in an empty workspace Feb 1, 2022
@meganrogge meganrogge self-assigned this Feb 1, 2022
@meganrogge meganrogge added this to the February 2022 milestone Feb 1, 2022
@meganrogge
Copy link
Collaborator Author

remote integration tests are failing on linux (and maybe mac?)

@meganrogge
Copy link
Collaborator Author

meganrogge commented Feb 1, 2022

ok so here's the problem:
Screen Shot 2022-02-01 at 4 45 00 PM
likely because this is true

} else if (this._cwd !== this._userHome) {

@meganrogge
Copy link
Collaborator Author

failures are unrelated ✅

@meganrogge meganrogge requested a review from Tyriar February 1, 2022 23:51
@meganrogge meganrogge merged commit a3053f7 into main Feb 2, 2022
@meganrogge meganrogge deleted the merogge/workspace branch February 2, 2022 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening a terminal in an empty restricted window

1 participant