finalize terminal disablePersistence API#141898
Conversation
Tyriar
left a comment
There was a problem hiding this comment.
Think we'll need to bring it up in the API sync but this looks like what I'd expect
|
I am surprised myself but we actually haven't used the |
|
That would mean we use a different word for the feature only in the api though? |
|
Sure - I'd say that's the norm and not an exception... Settings, command ids etc are kinda API but don't go by any rules. And these names also must not always aline |
|
@jrieken should we discuss the name at the next API sync or is this good to merge? |
|
I see we use
|
|
Yeah, we will probably do a quick mention at the next API sync. Tho, I don't expect this to be controversial or anyone of you to be there to "defend" it. |
|
Thanks so much @meganrogge!!! This will really improve the user experience for a lot of extensions. |
This PR fixes #118726