Skip to content

Change American time format to ISO time format#141353

Closed
icepaq wants to merge 3 commits intomicrosoft:mainfrom
icepaq:main
Closed

Change American time format to ISO time format#141353
icepaq wants to merge 3 commits intomicrosoft:mainfrom
icepaq:main

Conversation

@icepaq
Copy link
Copy Markdown
Contributor

@icepaq icepaq commented Jan 25, 2022

This PR fixes #140434

How to Test

  1. Go to the extensions tab
  2. Search for an extension (eg "Prettier")
  3. Ensure that the "Released on" and "Last updated" fields follow a YYYY-MM-DD, HH:MM:SS format.

@icepaq icepaq changed the title change American time format to ISO time format Change American time format to ISO time format Jan 25, 2022
@icepaq
Copy link
Copy Markdown
Contributor Author

icepaq commented Jan 25, 2022 •
edited
Loading

Before
image

After
image

@icepaq icepaq marked this pull request as draft January 25, 2022 04:16
@icepaq icepaq marked this pull request as ready for review January 25, 2022 04:17
@sandy081 sandy081 added this to the February 2022 milestone Jan 27, 2022
@sandy081 sandy081 self-requested a review January 27, 2022 14:31
@sandy081 sandy081 modified the milestones: February 2022, March 2022 Feb 25, 2022
@aifreedom
Copy link
Copy Markdown
Contributor

aifreedom commented Mar 8, 2022

Instead of supporting only ISO format, can we make it follow the datetime format set in the OS settings?

@icepaq
Copy link
Copy Markdown
Contributor Author

icepaq commented Mar 11, 2022 •
edited
Loading

Instead of supporting only ISO format, can we make it follow the datetime format set in the OS settings?

@aifreedom I briefly looked into this. It should be doable. But not necessarily an easy task.

@aifreedom
Copy link
Copy Markdown
Contributor

aifreedom commented Mar 11, 2022

Or can we get the locale from VS Code (https://code.visualstudio.com/docs/getstarted/locales) and format the date to string using Date.prototype.toLocaleDateString()?

@sandy081 sandy081 modified the milestones: March 2022, April 2022 Mar 21, 2022
@icepaq
Copy link
Copy Markdown
Contributor Author

icepaq commented Mar 25, 2022

@aifreedom Good idea!

@TylerLeonhardt TylerLeonhardt modified the milestones: April 2022, May 2022 Apr 29, 2022
@aifreedom
Copy link
Copy Markdown
Contributor

aifreedom commented May 13, 2022

@icepaq are you going to update this PR to do it that way? Or if you don't have time, I can open one.

@icepaq
Copy link
Copy Markdown
Contributor Author

icepaq commented May 13, 2022

@aifreedom Yeah feel free to take over this issue. Although I'd suggest keeping this in the same PR just because this has a bit more of a track record.

@aifreedom
Copy link
Copy Markdown
Contributor

aifreedom commented May 20, 2022

I don't think I can update this PR because that requires permission to push to your branch. I'll give it a try. If no luck, I'll reference this PR in the new one I will open.

@aifreedom aifreedom mentioned this pull request May 22, 2022
Merged
@sandy081
Copy link
Copy Markdown
Member

sandy081 commented May 23, 2022

Closing this in favour of #150133

@sandy081 sandy081 closed this May 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandy081 sandy081 Awaiting requested review from sandy081

1 more reviewer

@KendallDoesCoding KendallDoesCoding KendallDoesCoding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sandy081 sandy081

Labels

None yet

Projects

None yet

Milestone

May 2022

Development

Successfully merging this pull request may close these issues.

Dates on extension page use American format regardless of display language

5 participants

@icepaq @aifreedom @sandy081 @KendallDoesCoding @TylerLeonhardt