Skip to content

Fix connection token parsing#140532

Merged
aeschli merged 1 commit intomicrosoft:mainfrom
jeanp413:fix-server-token-parsing
Jan 12, 2022
Merged

Fix connection token parsing#140532
aeschli merged 1 commit intomicrosoft:mainfrom
jeanp413:fix-server-token-parsing

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Jan 12, 2022

Minor fix for the server connection token, connectionToken = generateUuid(); was being executed even if --connection-token was provided

cc @aeschli

@jeanp413 jeanp413 changed the title Fix conection token parsing Fix connection token parsing Jan 12, 2022
@aeschli aeschli merged commit f6b7c20 into microsoft:main Jan 12, 2022
@aeschli
Copy link
Contributor

aeschli commented Jan 12, 2022

@jeanp413 thanks a lot for catching this!

@aeschli aeschli added this to the January 2022 milestone Jan 12, 2022
@aeschli aeschli assigned aeschli and unassigned roblourens Jan 12, 2022
@aeschli aeschli added server bug Issue identified by VS Code Team member as probable bug and removed triage-needed labels Jan 12, 2022
@jeanp413 jeanp413 deleted the fix-server-token-parsing branch January 12, 2022 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Issue identified by VS Code Team member as probable bug server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants