Update ripgrep binaries to include ppc64le and s390x#140028
Merged
roblourens merged 1 commit intomicrosoft:mainfrom Jan 3, 2022
Merged
Update ripgrep binaries to include ppc64le and s390x#140028roblourens merged 1 commit intomicrosoft:mainfrom
roblourens merged 1 commit intomicrosoft:mainfrom
Conversation
ripgrep is a binary dependency, which gets pulled in through vscode-ripgrep, which itself downloads binaries from https://github.com/microsoft/ripgrep-prebuilt. The v13.0.0-2 of ripgrep-prebuilt (and only this version) didn't include binaries for s390x and ppc due to a change in CI infrastructure. The newer version v13.0.0-4 includes those binaries again (and has no other user-visible changes, see https://github.com/microsoft/ripgrep-prebuilt/releases). The previously used version of vscode-ripgrep pulled in v13.0.0-2 of the prebuilt binaries. The newer version 1.13.2 pulls in v13.0.0-4 of the binaries. Again, this version bump only includes the changes to the binaries and nothing else (see also microsoft/vscode-ripgrep@v1.12.1...v1.13.2 The version numbers are slightly misleading here.)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ripgrep is a binary dependency, which gets pulled in through
vscode-ripgrep, which itself downloads binaries from
https://github.com/microsoft/ripgrep-prebuilt. The v13.0.0-2
of ripgrep-prebuilt (and only this version) didn't include
binaries for s390x and ppc due to a change in CI
infrastructure. The newer version v13.0.0-4 includes those binaries
again (and has no other user-visible changes, see
https://github.com/microsoft/ripgrep-prebuilt/releases).
The previously used version of vscode-ripgrep pulled in
v13.0.0-2 of the prebuilt binaries. The newer version 1.13.2
pulls in v13.0.0-4 of the binaries. Again, this version bump
only includes the changes to the binaries and nothing else
(see also
microsoft/vscode-ripgrep@v1.12.1...v1.13.2
The version numbers are slightly misleading here.)