Add FontStyle.Strikethrough support#139413
Merged
Conversation
FontStyle.Strikethrough WIPFontStyle.Strikethrough support
Author
|
Does the |
Member
|
I have tested that everything is wired correctly using: I then tested it with a TypeScript file where there was an enum and with a markdown file where there was some bold text. In order for
@sndst00m I suggest we merge this PR because it adds support for strikethrough, and then pursue 1. and 2. in a subsequent PR |
Author
|
I have already made the PR for strikethrough in the Markdown grammar🥳 microsoft/vscode-markdown-tm-grammar#100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds support for strikethrough fontStyle from Textmate spec and Sublime Text ecosystem.
Part of #43504 epic.