Add extension information to snippet picker#138880
Merged
jrieken merged 4 commits intomicrosoft:mainfrom Dec 14, 2021
Merged
Conversation
|
|
eaa6829 to
65b50af
Compare
jrieken
reviewed
Dec 13, 2021
Member
jrieken
left a comment
There was a problem hiding this comment.
Thanks. This is looking very good. Left some nit comments, just in case you want to tackle those
Co-authored-by: David Wang <daviwang@umich.edu>
Co-authored-by: David Wang <daviwang@umich.edu>
65b50af to
d51d029
Compare
Contributor
Author
|
I also noticed an Electron unit test was failing earlier on Actions but not on my local. Should I be concerned with that? |
jrieken
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #138105.
To test this: