[Markdown] Adding support for GitHub themed images#137820
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Dec 7, 2021
lostintangent:main
Merged
[Markdown] Adding support for GitHub themed images#137820mjbvz merged 1 commit intomicrosoft:mainfrom lostintangent:main
mjbvz merged 1 commit intomicrosoft:mainfrom
lostintangent:main
Conversation
Collaborator
|
Should this be in https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles instead? |
Member
Author
|
The main reason I was thinking it might make sense to include this in a VS Code built-in extension, is so it would be available in Remote Repositories, GitHub.dev, Codespaces, etc. without needing to install anything else. That way it felt like a native experience for GitHub contexts, just like this is natively supported in GitHub.com. That said, we could also just auto-install the extension you mentioned in GitHub.dev and Codespaces, and achieve the same effect. So I'm cool with whichever approach you think makes the most sense 👍 |
Collaborator
|
Thanks for the details @lostintangent I agree having it in core makes sense then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub recently added support for appending
#gh-dark-mode-only/#gh-light-mode-onlyto the end of a Markdown image's URL, in order to hide/show images based on the end-user's active color theme (Details). This PR simply adds the equivalent support to the VS Code markdown preview.Note: I added this support to the built-in
githubextension, since the URL marker is technically GitHub specific, and therefore, felt appropriate being a part of the core GitHub capabilities. That said, let me know if this seems like it should be part of a different built-in extension 👍🏼