Make typings on showInformationMessage, showWarningMessage, showErrorMessage strict with items as strings#137672
Merged
jrieken merged 1 commit intomicrosoft:mainfrom Dec 9, 2021
Merged
Conversation
…ErrorMessage` strict with items as strings
Contributor
Author
|
I also wanted to make suggestions work with How do you handle breaking changes here in |
Member
Very simple: make no breaking changes. |
jrieken
approved these changes
Dec 8, 2021
raghavthind2005
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #
As I understand these changes should go here instead of DefinitelyTyped repo.
By API these methods return only these strings that developer passes as arguments, so why don't we make him happy with actual items suggestions in IDE?