Skip to content

Wait for extension contributions in welcome.showAllWalkthroughs#135632

Merged
JacksonKearl merged 4 commits intomicrosoft:mainfrom
yume-chan:patch-2
Mar 3, 2022
Merged

Wait for extension contributions in welcome.showAllWalkthroughs#135632
JacksonKearl merged 4 commits intomicrosoft:mainfrom
yume-chan:patch-2

Conversation

@yume-chan
Copy link
Contributor

@yume-chan yume-chan commented Oct 22, 2021

This PR fixes #135487

Another option is to hide Get Started: Open Walkthrough... and Get Started: Go Back commands from command palette (especially the go back, doesn't seem to be useful, as closeFindWidget command is not there)

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Oct 22, 2021

Thanks for the PR! I agree Get Started: Go Back should not be in F1 menu, but I disagree that Get Started: Open Walkthrough... should not.

For this patch, if I remember correctly the issue with waiting for the extensions to be registered is that it may depend on the file system being scanned to facilitate the featuredFor flag, which could amount to a large delay. The real fix would be to provide the list without waiting for that scan, as we perhaps don't need it for this case. Or, configuring the quick pick to stream in walkthroughs as they are added.

@JacksonKearl JacksonKearl self-requested a review October 23, 2021 00:51
@yume-chan
Copy link
Contributor Author

yume-chan commented Oct 23, 2021 •
edited
Loading

Now I show the quick pick immediately with built-in walk throughs and a loading indicator, then update the quick pick items after all extension contributions are fetched.

@yume-chan
Copy link
Contributor Author

yume-chan commented Oct 23, 2021

The failed tests are from integrated terminal.

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Mar 3, 2022

Thanks for working on this!

@JacksonKearl JacksonKearl merged commit c7eeab6 into microsoft:main Mar 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JacksonKearl JacksonKearl Awaiting requested review from JacksonKearl

Assignees

@JacksonKearl JacksonKearl

Labels

None yet

Projects

None yet

Milestone

March 2022

Development

Successfully merging this pull request may close these issues.

List extension walkthroughs in the `Get Started: Open Walkthrough ..." picker

2 participants

@yume-chan @JacksonKearl