Fix repository field parsing in extension editing#131293
Closed
wangweixuan wants to merge 3 commits into
Closed
Conversation
SaadbinWaheed
previously approved these changes
Aug 21, 2021
Author
|
Just fixed an edge case, where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the parsing of
repositoryfield in extension editing, allowingrepositoryshorthand, and avoids false reports of non-https relative image links.I add a dependency
hosted-git-info, which supports parsing repository shorthands and is developed by npm.I only fixed the warning message when authoring extensions. Actually vsce has not supported those shorthands by now. (microsoft/vscode-vsce#489)
This PR fixes #60669.