Skip to content

click on disabled breakpoint enable instead of removing #125904#125931

Merged
isidorn merged 4 commits intomicrosoft:mainfrom
xgdgsc:patch-1
Aug 4, 2021
Merged

click on disabled breakpoint enable instead of removing #125904#125931
isidorn merged 4 commits intomicrosoft:mainfrom
xgdgsc:patch-1

Conversation

@xgdgsc
Copy link
Contributor

@xgdgsc xgdgsc commented Jun 10, 2021 •
edited
Loading

This PR fixes #125904. This is only a trial edit in browser from a shallow understanding of the code section. Please correct me if I'm wrong.

@weinand weinand assigned isidorn and unassigned weinand Jun 10, 2021
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 10, 2021
@isidorn
Copy link
Collaborator

isidorn commented Jun 11, 2021

Thanks for the PR. However please setup VS Code so you can build it and try this out. Check this document out https://github.com/microsoft/vscode/wiki/How-to-Contribute

  1. You have a whitespace missing
  2. Your proposed solution is very complex imho, if some of the breakpoints are enabled and some disabled flip each?! This will be very hard to understand

What I propose is the following:

  1. If all breakpoints on the line are disabled -> enable them all
  2. Otherwise remove them all

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Jun 19, 2021 •
edited
Loading

I' m trying to setup build env on Windows. But it fails at

gyp http GET https://electronjs.org/headers/v12.0.11/node-v12.0.11-headers.tar.gz
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: Client network socket disconnected before secure TLS connection was established
gyp ERR! stack     at connResetException (internal/errors.js:628:14)
gyp ERR! stack     at TLSSocket.onConnectEnd (_tls_wrap.js:1561:19)
gyp ERR! stack     at TLSSocket.emit (events.js:387:35)
gyp ERR! stack     at endReadableNT (internal/streams/readable.js:1317:12)
gyp ERR! stack     at processTicksAndRejections (internal/process/task_queues.js:82:21)
gyp ERR! System Windows_NT 10.0.19043
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd D:\Documents\GitHub\vscode\node_modules\node-pty

which tries to download https://electronjs.org/headers/v12.0.11/node-v12.0.11-headers.tar.gz , one file I couldn' t download even with VPN. Any workarounds?

@isidorn
Copy link
Collaborator

isidorn commented Jun 22, 2021

Sorry I never saw that error. I do not know.

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Jul 20, 2021 •
edited
Loading

Thanks to #124467 (which could be closed) I managed to install the dependencies to run vscode. From what I tested it seems to do what I expected. I don' t get why you say "flip each".

@weinand weinand added this to the August 2021 milestone Aug 4, 2021
@isidorn
Copy link
Collaborator

isidorn commented Aug 4, 2021

@xgdgsc Works like magic. Thanks a lot for your contribution 👏

@isidorn isidorn merged commit b343c41 into microsoft:main Aug 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@isidorn isidorn

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Milestone

August 2021

Development

Successfully merging this pull request may close these issues.

click on disabled breakpoint , option to enable instead of removing

3 participants

@xgdgsc @isidorn @weinand