Allow Markdown-Rendering Without Providing an Env-Parameter #117041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
In order to create this PR I had to update the Is there some workaround for such cases? |
mjbvz
requested changes
Feb 19, 2021
Collaborator
mjbvz
left a comment
There was a problem hiding this comment.
There are a lot of changes here that seem unrelated to the original issue. These may be ok, but please submit them in a separate PR
Based on your description, it sounds like to prevent the crash, we just need to check if env is undefined in addImageStabilizer (the image stabilizer logic won't make any sense for external consumers anyways, so IMO it's fine to not support it here)
mjbvz
reviewed
Feb 22, 2021
Collaborator
|
Thanks! This will be in the next VS Code insiders build and is scheduled to go out with VS Code 1.54 |
Contributor
Author
|
Awesome thank you very much! ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #116987
Since the introduction of the new feature for stabilizing images, passing an
env-parameter to themarkdown-it-parser became mandatory as seen here:vscode/extensions/markdown-language-features/src/markdownEngine.ts
Lines 161 to 168 in a47f324
As my extension uses vscode's
markdown-it-parser, having to provide anenv-object with pre-defined properties is quite inconvenient. For that reason I created this PR which makes passing anenv-object optional as the necessaryenv.containingImages-property is created on the fly, if necessary, using a newinitialize_vscode_image_stabilizer-rule.