Consolidate wrapWithAbbreviation and wrapIndividualLinesWithAbbreviation in one command
#116603
+177
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iation` in one command Use aync/await and some cleanup
rzhao271
reviewed
Feb 16, 2021
Contributor
Author
|
Added 2 unit test for the issues explained in the first comment |
rzhao271
requested changes
Feb 17, 2021
rzhao271
reviewed
Feb 17, 2021
rzhao271
approved these changes
Feb 19, 2021
Collaborator
|
Thanks for the PR and polish! Merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #109191
Also fixes this issues I found while testing:
When using multi cursor, an error is thrown if the computed ranges overlap
If we type an invalid emmet abbreviation and press
enterthe preview changes and selections aren't reverted