Fix vscode becomes unresponsive after pasting filename with many dots in explorer #116268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheh
reviewed
Feb 10, 2021
| // (most file systems do not allow files > 255 length) with lots of `.` characters | ||
| // https://github.com/microsoft/vscode/issues/116199 | ||
| if (name.length <= 255) { | ||
| const dotSegments = name.split('.'); |
There was a problem hiding this comment.
Suggestion: Instead of the name length check, could we simply limit the number of items in dotSegment? e.g.
name.split('.').slice(-5));
That would at least show some of the class extensions?
Member
|
Thanks, I think we can go with this suggested change 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chose to ignore filenames whose length > 255 to avoid an explosive combination of extensions
Another option would be to just use the last
nextensionscc @bpasero let me know what you think
This PR fixes #116199