Skip to content

Conversation

@pfitzseb
Copy link
Contributor

This PR fixes #105229 by adding a Julia grammar file pulled in from https://github.com/JuliaEditorSupport/atom-language-julia.

@ghost
Copy link

ghost commented Jan 28, 2021

CLA assistant check
All CLA requirements met.

@aeschli aeschli added this to the February 2021 milestone Jan 28, 2021
@aeschli aeschli added the languages-basic Basic language support issues label Jan 28, 2021
@aeschli
Copy link
Contributor

aeschli commented Jan 28, 2021

Thanks a lot @pfitzseb !

@davidanthoff
Copy link
Contributor

Once this is merged and shipping, do we remove these parts from the Julia extension? Or is it best practice to still ship things in our extension in addition to having it in the core VS Code?

@aeschli
Copy link
Contributor

aeschli commented Feb 8, 2021

It would be best if you remove the duplication (grammar, language definition, language configuration) and instead depend on the basic extension.
You can always temporarily adding them back,e.g. if needed for an urgent fix when you don't want to wait for the next VSCode stable.

@aeschli aeschli self-requested a review February 8, 2021 10:43
@pfitzseb
Copy link
Contributor Author

pfitzseb commented Feb 8, 2021

What's going on with the conversion code? Is this something I can/should fix upstream?

@aeschli aeschli merged commit c86be3b into microsoft:master Feb 8, 2021
@aeschli
Copy link
Contributor

aeschli commented Feb 8, 2021

We had a bug in our grammar updater related to unicode. I pushed a fix 5cfa6b7 (microsoft/vscode-grammar-updater@3c5e198)

Thanks a lot for all your work @pfitzseb !

I added a Julia sample code that we use to run tests against. Feel free to have it cover more Julia syntax.
We use it to understand the changes after a grammar or theme update. We compare the tokens generated can colors assigned with the last known result.
It's perfectly fine to update the expected test results after a grammar update if we think the changes are making sense,

FYI @alexr00

@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

languages-basic Basic language support issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Julia extension in the core VS Code product

3 participants