-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Add Julia grammar #115309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Julia grammar #115309
Conversation
|
Thanks a lot @pfitzseb ! |
|
Once this is merged and shipping, do we remove these parts from the Julia extension? Or is it best practice to still ship things in our extension in addition to having it in the core VS Code? |
|
It would be best if you remove the duplication (grammar, language definition, language configuration) and instead depend on the basic extension. |
|
What's going on with the conversion code? Is this something I can/should fix upstream? |
|
We had a bug in our grammar updater related to unicode. I pushed a fix 5cfa6b7 (microsoft/vscode-grammar-updater@3c5e198) Thanks a lot for all your work @pfitzseb ! I added a Julia sample code that we use to run tests against. Feel free to have it cover more Julia syntax. FYI @alexr00 |
This PR fixes #105229 by adding a Julia grammar file pulled in from https://github.com/JuliaEditorSupport/atom-language-julia.