Skip to content

Modernize CLI main #114623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bpasero merged 5 commits into from
Jan 20, 2021
Merged

Modernize CLI main #114623

bpasero merged 5 commits into from
Jan 20, 2021
+141 −75

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Jan 20, 2021

Some cleanp to align this main entry point with the recent changes I did in shared process.

Besides cleanup, this:

  • adds gracefulfs
  • adds a unexpected error handler
  • disposes services on process exit

This needs a little adoption in remoteExtensionManagement that I will push after.

@bpasero bpasero added this to the January 2021 milestone Jan 20, 2021
@bpasero bpasero requested a review from sandy081 January 20, 2021 09:38
@bpasero bpasero self-assigned this Jan 20, 2021
@bpasero bpasero changed the title Refactor CLI main Modernize CLI main Jan 20, 2021
sandy081
sandy081 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. Thanks.

@bpasero bpasero merged commit 6c4203f into master Jan 20, 2021
@bpasero bpasero deleted the ben/cli-main-polish branch January 20, 2021 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandy081 sandy081 sandy081 approved these changes

Assignees

@bpasero bpasero

Labels

None yet

Projects

None yet

Milestone

January 2021

Development

Successfully merging this pull request may close these issues.

3 participants

@bpasero @sandy081