Skip to content

Fixes 114236: Add a multi-line comment regex to unIndentedLinePattern #114478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjbvz merged 3 commits into from
Feb 10, 2021
Merged

Fixes 114236: Add a multi-line comment regex to unIndentedLinePattern #114478

mjbvz merged 3 commits into from
Feb 10, 2021
+46 −1

Conversation

@shskwmt
Copy link
Contributor

@shskwmt shskwmt commented Jan 17, 2021

This PR fixes #114236

114236-2021-01-17_12.50.06.mp4

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 19, 2021

Can you please also add a test for this? The tests are here and can be run with the TypeScript extension tests debug configuration:

vscode/extensions/typescript-language-features/src/test/unit/onEnter.test.ts

Line 30 in 0faf155

suite.skip('OnEnter', () => {
(note that they are currently skipped since they were not reliable in CI, but seem to run locally)

@mjbvz mjbvz requested review from alexdima and rebornix January 19, 2021 22:19
@alexdima alexdima removed their request for review January 20, 2021 12:50
@mjbvz mjbvz added this to the February 2021 milestone Jan 25, 2021
@shskwmt
Copy link
Contributor Author

shskwmt commented Jan 28, 2021

@mjbvz
Thank you for reviewing. I added some tests.

Screenshot from 2021-01-29 05-52-59

@mjbvz mjbvz merged commit 76524ef into microsoft:master Feb 10, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 10, 2021

Thanks! This will be in the next VS Code insiders build and is scheduled for the 1.54 release

@shskwmt shskwmt deleted the fix/114236 branch February 10, 2021 01:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rebornix rebornix Awaiting requested review from rebornix

Assignees

@mjbvz mjbvz

Labels

None yet

Projects

None yet

Milestone

February 2021

Development

Successfully merging this pull request may close these issues.

[javascript] Leading space is added for new line when code block is preceded by multi-line comment block

2 participants

@shskwmt @mjbvz