Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #114473
The string
${abc:test} ${abc}would result incommandValueMappinghaving:{ "abc": "${abc}", "abc:test": "${abc:test}" }where
resolveFromMapwould get"abc"for both variables, resulting in${abc:test}being replaced with${abc}, disregarding the splitting ofabc:testinto['abc', 'test']that happened beforehand.This PR makes the call to
resolveFromMaprecreate the original variable ("abc:test") to pass to it. Running the example code in the mentioned issue with this fix produces the following output:The
${abc:test}remains${abc:test}, unlike before where it would've been "resolved" to${abc}instead.