Skip to content

Shell paths should be validated before launched to prevent ambiguous errors #72650

@Tyriar

Description

@Tyriar

We should validate the shell path exists and cache the result per window. Need to make sure it also works with symlinks.

image

There is this code that is meant to do this sort of thing right now but I think it's Windows only and also still just says "exit code 2":

https://github.com/Microsoft/vscode/blob/50c9a782ad2cf3b1b662966455187f8a9ec41bac/src/vs/workbench/contrib/terminal/node/terminalProcess.ts#L71-L77

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesterminalGeneral terminal issues that don't fall under another labelverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions