Maximum call stack size exceeded error #61524
Description
First of all Tree is super performant. Thanks 👏
Steps to Reproduce:
- Install extension from https://github.com/kieferrm/vscode-22804 (preferred) or clone repo, open folder, and F5
- Run Crazy: Flood Problems View with Files from Command Palette
- Select 40000 files with 3 errors each
- Try filtering using filter input box. After some time when I clear the filter I see following error. I also see this error when I move the scroll bar while tree is being populated
ERR Maximum call stack size exceeded: RangeError: Maximum call stack size exceeded
at ListView._splice (file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/list/listView.js:109:41)
at ListView.splice (file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/list/listView.js:83:29)
at file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/list/splice.js:13:62
at Array.forEach (<anonymous>)
at CombinedSpliceable.splice (file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/list/splice.js:13:30)
at file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/list/listWidget.js:873:83
at EventBufferer.bufferEvents (file:///Users/sandy081/work/vscode/out/vs/base/common/event.js:433:21)
at List.splice (file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/list/listWidget.js:873:32)
at IndexTreeModel.refilter (file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/tree/indexTreeModel.js:111:23)
at ObjectTreeModel.refilter (file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/tree/objectTreeModel.js:71:24)
at WorkbenchObjectTree.AbstractTree.refilter (file:///Users/sandy081/work/vscode/out/vs/base/browser/ui/tree/abstractTree.js:224:24)
at MarkersPanel.updateFilter (file:///Users/sandy081/work/vscode/out/vs/workbench/parts/markers/electron-browser/markersPanel.js:201:23)
at file:///Users/sandy081/work/vscode/out/vs/workbench/parts/markers/electron-browser/markersPanel.js:319:27
at Emitter.fire (file:///Users/sandy081/work/vscode/out/vs/base/common/event.js:159:38)
at MarkersFilterAction.set [as filterText] (file:///Users/sandy081/work/vscode/out/vs/workbench/parts/markers/electron-browser/markersPanelActions.js:114:39)
at MarkersFilterActionItem.onDidInputChange (file:///Users/sandy081/work/vscode/out/vs/workbench/parts/markers/electron-browser/markersPanelActions.js:234:36)
at file:///Users/sandy081/work/vscode/out/vs/workbench/parts/markers/electron-browser/markersPanelActions.js:180:148
at file:///Users/sandy081/work/vscode/out/vs/base/common/async.js:189:28
at Object.notifySuccess [as _notify] (file:///Users/sandy081/work/vscode/out/vs/base/common/winjs.base.js:1191:59)
at Object.enter (file:///Users/sandy081/work/vscode/out/vs/base/common/winjs.base.js:867:30)
at Promise_ctor._run (file:///Users/sandy081/work/vscode/out/vs/base/common/winjs.base.js:1089:29)
at Promise_ctor._completed (file:///Users/sandy081/work/vscode/out/vs/base/common/winjs.base.js:1057:18)
at file:///Users/sandy081/work/vscode/out/vs/base/common/async.js:194:23