Skip to content

"Select all occurrences of find match" selects all in file even when "find in selection" is enabled #59961

@silversquirl

Description

@silversquirl

Issue Type: Bug

To reproduce:

  1. Press ctrl+f to open the find window
  2. Type a pattern to match
  3. Select some text
  4. Turn on "Find in selection" by pressing alt+L or pressing the button
  5. Use "Select all occurrences of find match" by pressing ctrl+shift+L

Expected behaviour: Selections will be created for every match within the currently selected text.
Actual behaviour: Selections are created for every match in the entire document, not just the currently selected text.

VS Code version: Code 1.27.2 (f46c4c4, 2018-09-12T16:17:45.060Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.86GB (6.45GB free)
Process Argv C:\Users\svankoten\AppData\Local\Programs\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugeditor-findEditor find operations

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions