FileSystemProvider Image uris with query string (or fragment) won't show in diff editor (thinks its binary) #58313
Description
Issue Type: Bug
I'm creating a new FileSystemProvider that needs to pack some extra information into the Uris (via the query string), but I've found that images won't be handled as images when loaded into the diff editor (it thinks they are binary files).
I've finally tracked the issue to this line #584: https://github.com/Microsoft/vscode/blob/96854113091424c07b28ba84b82b75a88b8455cb/src/vs/workbench/browser/parts/editor/resourceViewer.ts#L581-L587
I believe it should read:
mime = mimes.getMediaMime(descriptor.resource.path);I will submit a PR for this.
VS Code version: Code 1.27.1 (5944e81, 2018-09-06T09:21:18.328Z)
OS version: Windows_NT x64 10.0.17755
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008) |
| GPU Status | 2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled |
| Memory (System) | 31.93GB (16.07GB free) |
| Process Argv | C:\Users\Eric\AppData\Local\Programs\Microsoft VS Code\Code.exe |
| Screen Reader | no |
| VM | 0% |