Skip to content

Don't trigger the shift+enter keyboard shortcut while searching #53151

@fiendish

Description

@fiendish

Issue Type: Bug

  1. Open a Python file.
  2. Select something in the file.
  3. Press Cmd+F or Ctrl+F to start searching.
  4. Press Shift+Enter to find the previous match.
  5. Watch the Terminal pop up, probably with some garbage NameErrors about whatever you selected not being defined.

This is because Shift+Enter is the default keyboard shortcut for "Run Selection/Line in Python Terminal", but that shouldn't be firing during a search.

VS Code version: Code 1.24.1 (24f6262, 2018-06-13T17:41:50.128Z)
OS version: Darwin x64 17.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (2.34GB free)
Process Argv /Applications/Visual Studio Code.app/Contents/MacOS/Electron .
Screen Reader no
VM 0%
Extensions (10)
Extension Author (truncated) Version
bracket-pair-colorizer Coe 1.0.58
markdown-preview-github-styles bie 0.1.2
vscode-markdownlint Dav 0.18.0
jupyter don 1.1.4
gc-excelviewer Gra 2.1.24
rainbow-csv mec 0.4.2
python ms- 2018.6.0
rewrap stk 1.9.1
python-extended-snippets tus 0.0.1
markdown-all-in-one yzh 1.5.0

Metadata

Metadata

Assignees

Labels

*caused-by-extensionIssue identified to be caused by an extensionterminalGeneral terminal issues that don't fall under another label

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions