-
Notifications
You must be signed in to change notification settings - Fork 38.3k
Description
Bug Description
In src/vs/workbench/contrib/accessibility/browser/accessibleView.ts, the _navigationHint() method (line 867) has a keybinding placeholder missing its closing > delimiter.
The <keybinding:...> syntax is a placeholder resolved by resolveContentAndKeybindingItems(). Because the first placeholder is missing its closing >, it is not recognized and the raw placeholder text is shown to the user instead of the resolved keybinding label.
Code
private _navigationHint(): string {
return localize('accessibleViewNextPreviousHint',
"Show the next item{0} or previous item{1}.",
`<keybinding:${AccessibilityCommandId.ShowNext}`, // MISSING closing >
`<keybinding:${AccessibilityCommandId.ShowPrevious}>` // correct
);
}Steps to Reproduce
- Enable a screen reader
- Open the Accessible View (e.g. from terminal or chat)
- Open Accessible View Help
- Read the navigation hint text
Expected Behavior
The hint should read something like: "Show the next item (Alt+N) or previous item (Alt+P)." with both keybindings resolved.
Actual Behavior
The "Show Next" keybinding is displayed as raw placeholder text because the closing > is missing, while "Show Previous" is resolved correctly.
Fix
One-character fix — add the missing >:
- `<keybinding:${AccessibilityCommandId.ShowNext}`
+ `<keybinding:${AccessibilityCommandId.ShowNext}>`Impact
This is an accessibility issue - screen reader users cannot see the correct keybinding for navigating to the next item in the accessible view.