Skip to content

Missing closing '>' in keybinding placeholder breaks accessible view navigation hint #295411

@Vedag812

Description

@Vedag812

Bug Description

In src/vs/workbench/contrib/accessibility/browser/accessibleView.ts, the _navigationHint() method (line 867) has a keybinding placeholder missing its closing > delimiter.

The <keybinding:...> syntax is a placeholder resolved by resolveContentAndKeybindingItems(). Because the first placeholder is missing its closing >, it is not recognized and the raw placeholder text is shown to the user instead of the resolved keybinding label.

Code

private _navigationHint(): string {
    return localize('accessibleViewNextPreviousHint',
        "Show the next item{0} or previous item{1}.",
        `<keybinding:${AccessibilityCommandId.ShowNext}`,      // MISSING closing >
        `<keybinding:${AccessibilityCommandId.ShowPrevious}>`   // correct
    );
}

Steps to Reproduce

  1. Enable a screen reader
  2. Open the Accessible View (e.g. from terminal or chat)
  3. Open Accessible View Help
  4. Read the navigation hint text

Expected Behavior

The hint should read something like: "Show the next item (Alt+N) or previous item (Alt+P)." with both keybindings resolved.

Actual Behavior

The "Show Next" keybinding is displayed as raw placeholder text because the closing > is missing, while "Show Previous" is resolved correctly.

Fix

One-character fix — add the missing >:

- `<keybinding:${AccessibilityCommandId.ShowNext}`
+ `<keybinding:${AccessibilityCommandId.ShowNext}>`

Impact

This is an accessibility issue - screen reader users cannot see the correct keybinding for navigating to the next item in the accessible view.

Metadata

Metadata

Assignees

Labels

accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesbugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions