Skip to content

showTextDocument & vscode.diff always default to ViewColumn.One #27408

@eamodio

Description

@eamodio
  • VSCode Version: Code - Insiders 1.13.0-insider (770206a, 2017-05-26T05:14:23.944Z)
  • OS Version: Windows_NT ia32 10.0.16199

These 2 apis should honor the ViewColumn if specified, but if left undefined they should default to the column of the active editor

Having this will eliminate code in many extensions such as:

(window.activeTextEditor && window.activeTextEditor.viewColumn) || 1

Which fails for anything that isn't a text document (since viewColumn will be missing)

Metadata

Metadata

Assignees

Labels

apiunder-discussionIssue is under discussion for relevance, priority, approach

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions