-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Closed
Labels
confirmedIssue has been confirmed by VS Code Team memberIssue has been confirmed by VS Code Team memberdebtCode quality issuesCode quality issuesfile-watcherFile watcherFile watcherfreeze-slow-crash-leakVS Code crashing, performance, freeze and memory leak issuesVS Code crashing, performance, freeze and memory leak issueshelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded
Milestone
Description
Does this issue occur when all extensions are disabled?: Yes
- VS Code Version: 1.98.2
Important Context:
It affects the browser version of VSCode a lot, as high CPU will make everything feels broken on the browser -> UI stuck, no smart code, not able to open, view, and save files
Steps to Reproduce:
- Configure your VS Code settings to make it do not exclude folder like
**/node_mudules/** - The builtin TS extension will send lots of watch requests, leads server-main CPU 100% and not able to do anything else for a long time
Example:
- Open https://github.com/mustard-mh/kibana/tree/test-misconfigure with Codespaces
- Access the
processes.tsfile and try to access its imported files
For each new request, the baseWatcher will loop all requests and compute an ID which the result should be same for every request every time
vscode/src/vs/platform/files/node/watcher/baseWatcher.ts
Lines 81 to 87 in 3d6eb63
| for (const request of requests) { | |
| if (this.isCorrelated(request)) { | |
| this.correlatedWatchRequests.set(request.correlationId, request); | |
| } else { | |
| this.nonCorrelatedWatchRequests.set(this.computeId(request), request); | |
| } | |
| } |
Is there a reason why it needs to re-computed?
kylos101 and jeanp413kylos101, geropl and axonasif
Metadata
Metadata
Assignees
Labels
confirmedIssue has been confirmed by VS Code Team memberIssue has been confirmed by VS Code Team memberdebtCode quality issuesCode quality issuesfile-watcherFile watcherFile watcherfreeze-slow-crash-leakVS Code crashing, performance, freeze and memory leak issuesVS Code crashing, performance, freeze and memory leak issueshelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded
