Skip to content

merge editor's accessibility help dialog should use the command formatting that others do #244656

@meganrogge

Description

@meganrogge

Currently, the merge editor's a11y help dialog says:

You are in a merge editor.
Navigate between merge conflicts using the commands Go to Next Unhandled Conflict and Go to Previous Unhandled Conflict.
Run the command Merge Editor: Accept Merge to accept the current conflict.

It should follow suit with all of the other help dialogs that provide keybinding support. For example, in the terminal's:

The terminal has a feature called shell integration that offers an enhanced experience and provides useful commands for screen readers such as:
- Go to Next Command (Option+DownArrow) in the accessible view
- Go to Previous Command (Option+UpArrow) in the accessible view
- Go to Symbol (Shift+Command+O)
- Run Recent Command (Control+Option+R)
- Go to Recent Directory (Command+G)

This is made possible with this syntax:

export const nextRange = nls.localize('next', "- Go to Next Commenting Range{0}.", `<keybinding:${CommentCommandId.NextRange}>`);
export const previousRange = nls.localize('previous', "- Go to Previous Commenting Range{0}.", `<keybinding:${CommentCommandId.PreviousRange}>`);
export const nextCommentThread = nls.localize('nextCommentThreadKb', "- Go to Next Comment Thread{0}.", `<keybinding:${CommentCommandId.NextThread}>`);
export const previousCommentThread = nls.localize('previousCommentThreadKb', "- Go to Previous Comment Thread{0}.", `<keybinding:${CommentCommandId.PreviousThread}>`);
export const nextCommentedRange = nls.localize('nextCommentedRangeKb', "- Go to Next Commented Range{0}.", `<keybinding:${CommentCommandId.NextCommentedRange}>`);
export const previousCommentedRange = nls.localize('previousCommentedRangeKb', "- Go to Previous Commented Range{0}.", `<keybinding:${CommentCommandId.PreviousCommentedRange}>`);

Metadata

Metadata

Labels

accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesbugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions