-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Description
In current Insiders (and presumably the upcoming release), spawning a .bat file on Windows without shell: true fails due to a breaking change in NodeJS:
https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
It is important to note that there has been a breaking change for Windows users who utilize
child_process.spawnandchild_process.spawnSync. Node.js will now error withEINVALif a.bator.cmdfile is passed tochild_process.spawnandchild_process.spawnSyncwithout theshelloption set.
It appears that there's no way to signal this to DebugAdapterExecutable and therefore any .bat-based debug adapters launched this way fail in current Insiders (and will presumably fail in stable soon).
Could shell: bool? be added to DebugAdapterExecutableOptions? I don't know enough to contribute this, but this seems quite important.